-
Notifications
You must be signed in to change notification settings - Fork 12
properly implemented Accept-Encoding:gzip (and changed windows curl binary to haxx one with zlib support) #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@cielavenir please update the PATCH version in CMakeLists.txt thanks |
f4d1b4f
to
9057f20
Compare
8f749ce
to
c18609f
Compare
Done. Sorry to be late. The issue is that when we set I needed to replace whole libcurl msvc binary. I cleaned up openssl include as well, which is not read by controllerclientcpp build system. |
necessary? (@ziyan ) |
@ziyan currently controllerclientcpp does not use zlib |
I guess |
Let's move to #108 |
Tested on Windows as well.
However, unfortunately it turned out our libcurl binary does not enable zlib. I needed to use https://curl.haxx.se/windows/ for testing.