properly implemented Accept-Encoding:gzip (and changed windows curl binary to haxx one with zlib support) #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cielavenir please update the PATCH version in CMakeLists.txt thanks |
cielavenir
force-pushed
the
encodingDeflate
branch
from
f4d1b4f to
9057f20
Compare
cielavenir
force-pushed
the
encodingDeflate
branch
from
8f749ce to
c18609f
Compare
|
Done. Sorry to be late. The issue is that when we set I needed to replace whole libcurl msvc binary. I cleaned up openssl include as well, which is not read by controllerclientcpp build system. |
cielavenir
changed the title
cielavenir
changed the title
|
necessary? (@ziyan ) |
|
@ziyan currently controllerclientcpp does not use zlib |
|
I guess |
|
Let's move to #108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Windows as well.
However, unfortunately it turned out our libcurl binary does not enable zlib. I needed to use https://curl.haxx.se/windows/ for testing.