-
Notifications
You must be signed in to change notification settings - Fork 4
Full support to pnpm
and more
#22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…tput code (-2.5%)
…updated, created or deleted This way it is possible to guarantee changes in the Package Manager that may have occurred (eg. changed from NPM to PNPM)
5c1a95b
to
19ff6ea
Compare
In cases where the locker file already exists but the `node_modules` folder has not yet been installed via `npm install` or similar, the locker itself will not be changed directly and a diagnostics review will not be performed.
@mskelton Did you think possible approves this PR? If the mentioned changes, especially regarding the ESM, are not in line with the project's current momentum, I will respect it. I just wanted your answer, as I share the extension with others, it would be nice to use it directly from the vscode repository. If it's not feasible for you, I would like to create a separate extension as a continuation of this one (although I really prefer to keep this one). |
…the package.json itself instead of the workspace itself
@rentalhost maybe create a temporary extension that highlights pnpm support and deprecate it as soon as it's merged. The problems fixed here have been driving me nuts for weeks and I'd have loved to have found a fix earlier. |
@wycats I have published now as npm-outdated plus. |
Paging Dr @mskelton |
Hey all, sorry for the late reply. I've kind of been ignoring this repo since there has been a lot of good activity, but it hasn't be super relevant in my day to day. Glad to see you pushing the project forward. @rentalhost To your questions, I'd say guide this project however you see best. If ESM is causing issues, feel free to drop it. I migrated most of my projects just for standardization, but if that's not the best for this, totally fine. |
@mskelton maybe make @rentalhost a maintainer so they can push this forward? |
@wycats He already is a collaborator on the repo. |
Added full support for
pnpm
, together with the already supportednpm
. Currently there is no support foryarn
, but I believe this could be done at some point.New features:
pnpm
;pnpm-lock.yaml
and the ownpackage.json
;peerDependencies
;npm
orpnpm
command (which is unlikely, but may happen);pnpm
as the package manager for the extension from now on;swc
, which reduces the size of the compiled extension (vsix file) by about 3.6%, despite the new features.Big problem:
Unfortunately, I was not able to adapt to using ESM as the latest version of the extension. I don't know what to do. So since I'm more adapted to the "old way" and to be able to work quickly on these features, I decided to step back and base it on what I already know.
I don't know if it will be possible to continue with this PR like this.