Skip to content

Full support to pnpm and more #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Full support to pnpm and more #22

wants to merge 17 commits into from

Conversation

rentalhost
Copy link
Collaborator

@rentalhost rentalhost commented May 10, 2023

Added full support for pnpm, together with the already supported npm. Currently there is no support for yarn, but I believe this could be done at some point.

New features:

  • Full support for the package manager pnpm;
  • Support for monorepos and multiple workspaces (previously only the first folder in the workspace was supported, and the others presented conflicting results, as they used the first folder as reference). This is a new feature and at the same time a bug fix;
  • Improvement in the file watcher of lock files:
  • Include support to peerDependencies;
  • Code intelligence for the extension to be "soft-disabled" if it is not possible to detect the presence of the npm or pnpm command (which is unlikely, but may happen);
  • Using pnpm as the package manager for the extension from now on;
  • Post-optimization of code using swc, which reduces the size of the compiled extension (vsix file) by about 3.6%, despite the new features.
  • Updated code style and using most updated dependencies;

Big problem:

Unfortunately, I was not able to adapt to using ESM as the latest version of the extension. I don't know what to do. So since I'm more adapted to the "old way" and to be able to work quickly on these features, I decided to step back and base it on what I already know.

I don't know if it will be possible to continue with this PR like this.

@rentalhost rentalhost added the enhancement New feature or request label May 10, 2023
@rentalhost rentalhost force-pushed the support-pnpm branch 3 times, most recently from 5c1a95b to 19ff6ea Compare May 10, 2023 01:03
david-rodrigues and others added 3 commits May 12, 2023 12:23
In cases where the locker file already exists but the `node_modules` folder has not yet been installed via `npm install` or similar, the locker itself will not be changed directly and a diagnostics review will not be performed.
@rentalhost
Copy link
Collaborator Author

@mskelton Did you think possible approves this PR? If the mentioned changes, especially regarding the ESM, are not in line with the project's current momentum, I will respect it. I just wanted your answer, as I share the extension with others, it would be nice to use it directly from the vscode repository. If it's not feasible for you, I would like to create a separate extension as a continuation of this one (although I really prefer to keep this one).

…the package.json itself instead of the workspace itself
@wycats
Copy link

wycats commented Jul 25, 2023

@rentalhost maybe create a temporary extension that highlights pnpm support and deprecate it as soon as it's merged.

The problems fixed here have been driving me nuts for weeks and I'd have loved to have found a fix earlier.

@rentalhost
Copy link
Collaborator Author

rentalhost commented Jul 26, 2023

@wycats I have published now as npm-outdated plus.

@paul-uz
Copy link

paul-uz commented Jul 28, 2023

Paging Dr @mskelton

@mskelton
Copy link
Owner

Hey all, sorry for the late reply. I've kind of been ignoring this repo since there has been a lot of good activity, but it hasn't be super relevant in my day to day. Glad to see you pushing the project forward.

@rentalhost To your questions, I'd say guide this project however you see best. If ESM is causing issues, feel free to drop it. I migrated most of my projects just for standardization, but if that's not the best for this, totally fine.

@wycats
Copy link

wycats commented Aug 15, 2023

@mskelton maybe make @rentalhost a maintainer so they can push this forward?

@mskelton
Copy link
Owner

@wycats He already is a collaborator on the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin stuck on "Ready-to-install package ... Just run your package manager install command."
5 participants