Skip to content

chore!: remove unused deps, convert to ES2015 class #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 11, 2023
Merged

chore!: remove unused deps, convert to ES2015 class #1633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ce4ec57
chore!: remove unused deps and make `new` required
robertsLando Jul 10, 2023
a2d27ad
refactor: convert to es2015 class
robertsLando Jul 10, 2023
488f03f
refactor: remove `pump`, use `pipeline`
robertsLando Jul 10, 2023
81c32db
chore: remove `inherits`
robertsLando Jul 10, 2023
7a69936
chore: run browser tests only on latest
robertsLando Jul 10, 2023
a871cec
fix: remove `xtend`
robertsLando Jul 11, 2023
19b120b
chore: audit fix
robertsLando Jul 11, 2023
8dcd727
fix: lint and missing `xtend` occurances
robertsLando Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/mqttjs-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ jobs:
DEBUG: "mqttjs"

- name: Test Browser
if: matrix.node-version == '20.x'
# only run on latest node version, no reason to run on all
timeout-minutes: 2
run: |
npm run browser-build
Expand Down
5 changes: 2 additions & 3 deletions bin/pub.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@
'use strict'

const mqtt = require('../')
const pump = require('pump')
const { pipeline, Writable } = require('readable-stream')
const path = require('path')
const fs = require('fs')
const concat = require('concat-stream')
const Writable = require('readable-stream').Writable
const helpMe = require('help-me')({
dir: path.join(__dirname, '..', 'doc')
})
Expand Down Expand Up @@ -40,7 +39,7 @@ function multisend (args) {
}

client.on('connect', function () {
pump(process.stdin, split2(), sender, function (err) {
pipeline(process.stdin, split2(), sender, function (err) {
client.end()
if (err) {
throw err
Expand Down
Loading