Fix select extend summary #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all fields possibly needed for downstream analysis
|
Feel free to make aesthetic improvements as long as they keep the logic intact :) Also, one more TODO is there, any idea how to tackle this? pheval.llm/src/malco/process/summary.py Line 14 in e6df878 |
|
I dont think we want the raw results in here. These should exist in the jsonl format. Lets meet to finish this merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks the combine command, but rather than seeing this as an issue, I'd like to see the combine command updated to work now, will do so in another commit before merging