-
Notifications
You must be signed in to change notification settings - Fork 7
Use ruff format
for code formatting
#1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for monarch-app canceled.
|
I'm not sure why the frontend linting test is failing. Is it not passing on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1032 +/- ##
==========================================
+ Coverage 70.97% 71.39% +0.42%
==========================================
Files 91 92 +1
Lines 3128 3188 +60
==========================================
+ Hits 2220 2276 +56
- Misses 908 912 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hmm, @ptgolden I tried re-running the lint test again and it still failed. When you get a chance can you take another look at this? |
Depending on how we feel about #890, that has a number of frontend dependency updates and makes use of now-deprecated methods of eslint config etc. that may resolve this. Edit: I was apparently missing some dependencies, |
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Related issues
Summary
Drops
black
as a dependency, in favor of usingruff format
as a formatter. On my machine, it's a ~100x speedup.There's a small change to the makefile too. Instead of using the
--exit-zero
flag inruff check
, the command is prefixed with-
to continue running even after a non-zero exit code.Checks