Skip to content

examples: add a simple chat client for example #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

jokemanfire
Copy link
Collaborator

  1. optimize the readme in root
  2. add example

Motivation and Context

for dev friendly

How Has This Been Tested?

just use it

Breaking Changes

no

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@jokemanfire jokemanfire force-pushed the dev branch 2 times, most recently from e3ce607 to 9e4dd6b Compare April 10, 2025 08:38
@jokemanfire jokemanfire requested a review from 4t145 April 10, 2025 08:39
1. optimize the readme in root
2. add example

Signed-off-by: jokemanfire <[email protected]>

1
@jokemanfire
Copy link
Collaborator Author

#58

Copy link
Collaborator

@4t145 4t145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@4t145 4t145 merged commit 2125698 into modelcontextprotocol:main Apr 10, 2025
8 checks passed
@jokemanfire jokemanfire mentioned this pull request Apr 14, 2025
Copy link
Contributor

@Hendler Hendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple quick comments. Thank you for having an example!

};

//default config path
const DEFAULT_CONFIG_PATH: &str = "/etc/simple-chat-client/config.toml";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for an example app, should use ./config.toml as to not need escalated privileges to read from /etc

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thks, I 'd like to add a arg, to point the config path.

"\ntool name: {}\ndescription: {}\nparameters: {}\n",
tool.name(),
tool.description(),
serde_json::to_string_pretty(&tool.parameters()).unwrap_or_default()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe have an example of error handling instead of hiding serialization issues?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants