-
Notifications
You must be signed in to change notification settings - Fork 137
examples: add a simple chat client for example #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e3ce607
to
9e4dd6b
Compare
1. optimize the readme in root 2. add example Signed-off-by: jokemanfire <[email protected]> 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple quick comments. Thank you for having an example!
}; | ||
|
||
//default config path | ||
const DEFAULT_CONFIG_PATH: &str = "/etc/simple-chat-client/config.toml"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for an example app, should use ./config.toml
as to not need escalated privileges to read from /etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thks, I 'd like to add a arg, to point the config path.
"\ntool name: {}\ndescription: {}\nparameters: {}\n", | ||
tool.name(), | ||
tool.description(), | ||
serde_json::to_string_pretty(&tool.parameters()).unwrap_or_default() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe have an example of error handling instead of hiding serialization issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right
Motivation and Context
for dev friendly
How Has This Been Tested?
just use it
Breaking Changes
no
Types of changes
Checklist
Additional context