Skip to content

Update calculator example description #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

look
Copy link
Contributor

@look look commented Apr 9, 2025

The example in the README uses "sum" for both sum and sub. I changed it to "difference". For consistency, I also updated the example code to use the same term.

Motivation and Context

I noticed the README was incorrect.

How Has This Been Tested?

No, example code only.

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

N/A

The example in the README uses "sum" for both `sum` and `sub`. I changed it to "difference". For consistency, I also updated the example code to use the same term.
Copy link
Collaborator

@jokemanfire jokemanfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@jokemanfire
Copy link
Collaborator

just fix the lint

@rikhuijzer
Copy link
Contributor

@look to maybe save you some time, I think this should fix the lint error:

$ git reset --soft HEAD~1

$ git add .

$ git commit -m "docs: update calculator example description"

$ git push --force

@jokemanfire jokemanfire merged commit dffae27 into modelcontextprotocol:main Apr 10, 2025
7 of 8 checks passed
@look
Copy link
Contributor Author

look commented Apr 10, 2025

Thanks for merging. Sorry I didn't see the lint warning because CI didn't run for me. I will make sure I lint locally next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants