N-API Support #36
Merged
N-API Support #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems CI is failing, could you take a look? |
|
Yes. https://ci.appveyor.com/project/jschlight/native-hdr-histogram/builds/34484967 |
|
I would propose to move to github actions for everything, wdyt? Can you make the change? |
|
Or use |
|
what works for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the current NAN implementation with an N-API implementation targeted to N-API v3.
In addition to the methods and properties previously added by @ccollie in PR #35, this PR adds the following methods:
See issue #34.