Skip to content

[Doc] improve AutocompleteInput create example #10696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2025

Conversation

Cimanel
Copy link
Contributor

@Cimanel Cimanel commented Apr 24, 2025

Problem

Current examples of in the docs leverage useCreate, and require calling create manually with data coming from self-managed controlled inputs.

It’s actually simpler to leverage , which removes the need to call create directly, and opens the ability to use

along with RA Input components.

Solution

Update the doc examples to use instead.

How To Test

the story to test: http://localhost:9010/?path=/story/ra-ui-materialui-input-autocompleteinput--inside-reference-input-with-creation-support

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

@Cimanel Cimanel added the WIP Work In Progress label Apr 24, 2025
@slax57 slax57 self-requested a review April 24, 2025 20:28
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, LGTM! You're on the right track!

@Cimanel Cimanel added RFR Ready For Review WIP Work In Progress and removed WIP Work In Progress RFR Ready For Review labels Apr 25, 2025
@slax57 slax57 self-requested a review April 25, 2025 12:18
@slax57 slax57 added this to the 5.7.4 milestone Apr 25, 2025
@slax57 slax57 merged commit 2d88ccf into master Apr 25, 2025
16 checks passed
@slax57 slax57 deleted the rewrite-autocompleteinput-create-examples branch April 25, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Development

Successfully merging this pull request may close these issues.

3 participants