LUTECE-2189 : Add a button to display the password on the login page #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The button is only added if javascript is active. When first loaded, the password is displayed with bullets. Displaying the password can help enter it, and thus encourage choosing a stronger one.
jonenst
reviewed
Jan 30, 2018
| @@ -49,4 +49,23 @@ | |||
| var bgImg = 'url(' + randomImages[rndNum] + ')'; | |||
| $("#login-page").css('background-image', bgImg ); | |||
| }); | |||
| $(document).ready(function() { | |||
| var buttonGroup = $("<span class='input-group-btn'><button type='button' class='btn btn-flat' title='${i18n('portal.admin.admin_login.showPassword')?html}'><span class='fa fa-eye'></span><span class='sr-only'>${i18n('portal.admin.admin_login.showPassword')?html}</span></button></span>"); | |||
There was a problem hiding this comment.
Should we use "message?js_string?html here" ? This way if we add the ' character it won't break ?
There was a problem hiding this comment.
It seems so, yes (for the occurence inside the title attibute)
There was a problem hiding this comment.
why not all -5- edit 6 occurences ?
There was a problem hiding this comment.
it cannot hurt to do it everywhere, I guess, but only this occurence is susceptible to break if a ' is unescaped.
?html escaping is sufficient because the values are only enclosed in double quotes, so single quote escapting is not necessary.
seboo
force-pushed
the
develop
branch
3 times, most recently
from
135e4f9 to
e399c1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button is only added if javascript is active. When first loaded, the password is
displayed with bullets.
Displaying the password can help enter it, and thus encourage choosing a stronger one.