fix(sequelize): add support for extended operators in sequelize #10284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postgres supports extended operators but missing in sequelize fix loopbackio#10272 Signed-off-by: Yesha Mavani <[email protected]>
Pull Request Test Coverage Report for Build 7502386386Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
samarpanB
reviewed
Jan 5, 2024
added test cases for same fix loopbackio#10272 Signed-off-by: Yesha Mavani <[email protected]>
added.. |
samarpanB
requested changes
Jan 9, 2024
| }, | ||
| }) | ||
| async getRolesByDesc(): Promise<Roles[]> { | ||
| return this.roleRepository.find({ |
There was a problem hiding this comment.
Its better to pass this as where clause from test case
added test cases fix loopbackio#10272 Signed-off-by: Yesha Mavani <[email protected]>
fix loopbackio#10272 Signed-off-by: Yesha Mavani <[email protected]>
samarpanB
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postgres supports extended operators but missing in sequelize
fix #10272
Please provide a high-level description of the changes made by your pull request.
postgres supports extended operators but missing in sequelize
added the supported operators
also the array field was by default given integer[] type even if it was string[].
added to condition to check before giving a default value.
Include references to all related GitHub issues and other pull requests, for example:
Fixes #10272
Example app to test - https://github.com/yeshamavani/sequelize
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈