Skip to content

Add final branch #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2025
Merged

Add final branch #17

merged 2 commits into from
Jun 10, 2025

Conversation

davicms
Copy link
Member

@davicms davicms commented Jun 5, 2025

No description provided.

@smbmatheus-lr smbmatheus-lr self-requested a review June 9, 2025 14:26
smbmatheus-lr
smbmatheus-lr requested changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@smbmatheus-lr smbmatheus-lr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR was not accepted.

The client extensions need to be deployed. So build them, add them to osgi/client extensions folders and add them to the pages etc. That should be the final branch - otherwise it will look like none of the exercises were completed.

@smbmatheus-lr smbmatheus-lr merged commit bc7ee1d into liferay:final Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smbmatheus-lr smbmatheus-lr smbmatheus-lr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davicms @smbmatheus-lr