fix(community): handle both Zod and JSON schemas in Watson tool conversion #8272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion The _convertToolToWatsonxTool function was assuming all tool schemas were Zod schemas and calling zodToJsonSchema on them. However, MCP tools already have JSON schemas, causing "Cannot read properties of undefined (reading 'typeName')" errors. - Add isZodSchema check before converting to JSON schema - Add unit test covering both Zod and JSON schema tools - Fixes compatibility with MCP (Model Context Protocol) tools
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
auto:bug
|
Thanks for the fix @christian-bromann! |
|
@hntrl awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the same
TypeError: Cannot read properties of undefined (reading 'typeName')error inChatWatsonxthat was fixed forChatMistralAIin #8269.Problem
The
_convertToolToWatsonxToolfunction had the same issue as MistralAI - it was assuming all tool schemas were Zod schemas and unconditionally callingzodToJsonSchema()on them. MCP tools and otherDynamicStructuredToolinstances already have JSON schemas, causing the conversion to fail.Solution
Applied the same fix as PR #8269:
isZodSchema()check before attempting schema conversionzodToJsonSchema()for actual Zod schemasChanges:
_convertToolToWatsonxTool()inlibs/langchain-community/src/chat_models/ibm.tsTesting
This enables MCP (Model Context Protocol) tools to work with
ChatWatsonx, just like the fix forChatMistralAI.Related