Skip to content

chore: Make the private variable __vs to semi private #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

dishaprakash
Copy link
Collaborator

chore: Make the private variable __vs to semi private

This change is being done as the AsyncPGVectorStore was being stored in the PGVectorStore as a private variable which hides it from the child class.
This PR converts it into a semi private variable

@averikitsch
Copy link
Collaborator

Closing this for now. We will try to keep the underlying Async VS private.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants