INTPYTHON-630 Fixes handling of ttlMonitorSleepSecs #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ttlMonitorSleepSecs was first reduced programatically via
client.admin.command(setParameter,ttlMonitorSleepSecs). This reduced the time required to test the TTL feature from 60 seconds to 2. This is because 60s is the frequency that the background process is kicked off at. However, this only worked on local Atlas. For Cloud Atlas, this feature requires that one setParameter manually vi the Atlas Administration UI. This PR is small. It just wraps client.admin.command(setParameter,ttlMonitorSleepSecs) in a try block. Crucially though, it comes at the same time as @blink1073 updated the parameter via API for our remote tests' cluster.See docs here.