Support num_partitions to decide no of partition other then default

[rgupta2508]

Give an option to select no of partition while creating collection.

[zc277584121]

@rgupta2508 it seems some small lint issues

[rgupta2508]

@rgupta2508 it seems some small lint issues

Resolved

[zc277584121]

@rgupta2508 seems still having lint issue

[rgupta2508]

I think there is something missing in this library build or milvus field reference, it is saying langchain_milvus/vectorstores/milvus.py:663: error: "Milvus" has no attribute "num_partitions" [attr-defined]
but it is supported in milvus in , and partation_key field we are giving in schema .
not sure how to resolve this?

[zc277584121]

@rgupta2508 maybe you missed the self.num_partitions = num_partitions

[zc277584121]

btw, why its type is str(I guess it should be int), and what is your expected end2end behavior when invoking this paramerter

[rgupta2508]

btw, why its type is str(I guess it should be int), and what is your expected end2end behavior when invoking this paramerter

@zc277584121 if we will enable partition key , it will create 64 partition by default for that column, i want to to control number of partition by this parameter.
https://milvus.io/docs/use-partition-key.md

[zc277584121]

i guess the lint issue is that you forgot to assign self.num_partitions = num_partitions

[zc277584121]

@rgupta2508 Just a reminder, you can run lint and test follow the contribution guide in your local enviroment to check before commit PR

[rgupta2508]

@rgupta2508 Just a reminder, you can run lint and test follow the contribution guide in your local enviroment to check before commit PR

Ok Thanks,
I have setup this environment in my local environemnt

[rgupta2508]

@zc277584121 can you please review this,
Sorry for delayed on this

[zc277584121]

/lgtm