[community]: [remove arbitrary return in google results] #939
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR fixes the implementation to match the documented behavior of this method.
Method's documentation clearly states that:
Much to my demise, there's a strange early return
if no results were found.
There's no need to represent the "emptiness" of results, an empty list takes care of that. In any case, if we need to represent the absence, this is not a sensible null pattern implementation, since the returned object is not even polymorphic wit h what the documentation says.
This PR removes that early return and considers that an empty list correctly represents the absence of results
Relevant issues
Type
🧹 Refactoring
📖 Documentation
Changes(optional)
Testing(optional)
Note(optional)