genai:Make legacy function calling kwarg function_call optional
#918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set default to False as it is legacy Included and updated tests
|
@lolamathematician linter if failing, could you double-check, please? plus, I don't think we should move test outside of "integration" or "unit" folders. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set default to False as it is legacy
Included and updated tests
PR Description
Adds option to not include (legacy) function calls in additional_kwargs in addition to tool calls. Other providers can raise an error if these are present in their calls.
This can come up if providers are mixed in a tool-calling loop.
We add a new optional flag to the ChatGoogleGenerativeAI model. Default to False for forward looking change.
Updated tests and added specific test for this change.
Type
🐛 Bug Fix
✅ Test