-
Notifications
You must be signed in to change notification settings - Fork 242
Genai: Integrate JSON Mode for Gemini 1.5 (flash) #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vishah02
wants to merge
11
commits into
langchain-ai:main
Choose a base branch
from
swepon:vi-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
261089f
added support for JSON mode
vishah02 d4ff189
Added tests, ran make lint
vishah02 3830ccb
Fixed Typing in Tets
vishah02 db1a210
Fix Typing error in Tests
vishah02 7ccaca5
deserialze json string to python list for testing
emma0925 78c074e
added tests to verify json feature
emma0925 c353979
linting fixed in some of the tests
vishah02 f06e804
Fixed use of validate_environment in tests
vishah02 83e826f
Merge branch 'main' into vi-test
emma0925 3603d55
Merge branch 'main' into vi-test
emma0925 7b1e367
Merge branch 'main' into vi-test
lkuligin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we avoid bringing additional dependencies like
google.generativeai
, please? We should usegoogle.ai.generativelanguage_v1beta.types
.