Harrison/changes #67
Open
Harrison/changes #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nfcampos
reviewed
Mar 16, 2025
| console.error('[Login] Login error:', error.message); | ||
| } | ||
| } catch (error) { | ||
| console.error('[Login] Error creating Supabase client or signing in:', error); |
There was a problem hiding this comment.
Try catch inside a react component is a bit odd, not usual
There was a problem hiding this comment.
Try catch on line 7 is weird. But this one is quite usual. I've used try catch within handler function.
Although hooks must not be wrapped in try catch. You can use try catch inside the hooks
It's an onclick handler function and it's completely fine. But Can use currying function to ensure component doesn't rerender
eg
const handleLogin = useCallback((loginMethod: string) => () {
}, [])
and on the button
onClick={handleLogin('google')}
|
|
||
| export function Thread() { | ||
| const { session } = useUser(); | ||
| const [data, setData] = useState(null); |
|
|
||
| return ( | ||
| <div> | ||
| {/* Your thread component UI */} |
| } | ||
| } | ||
|
|
||
| // Keeping for backward compatibility |
| assistantId, | ||
| threadId: threadId ?? null, | ||
| onCustomEvent: (event, options) => { |
There was a problem hiding this comment.
I'm assuming this is removed because you don't need genui for this app?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.