Skip to content

Harrison/changes #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Harrison/changes #67

wants to merge 3 commits into from

Conversation

hwchase17
Copy link

No description provided.

Copy link

vercel bot commented Mar 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langgraph-chat ❌ Failed (Inspect) Mar 16, 2025 3:32am

console.error('[Login] Login error:', error.message);
}
} catch (error) {
console.error('[Login] Error creating Supabase client or signing in:', error);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try catch inside a react component is a bit odd, not usual

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try catch on line 7 is weird. But this one is quite usual. I've used try catch within handler function.

Although hooks must not be wrapped in try catch. You can use try catch inside the hooks

It's an onclick handler function and it's completely fine. But Can use currying function to ensure component doesn't rerender

eg

const handleLogin = useCallback((loginMethod: string) => () {

}, [])

and on the button

onClick={handleLogin('google')}


export function Thread() {
const { session } = useUser();
const [data, setData] = useState(null);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this isn't used


return (
<div>
{/* Your thread component UI */}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful UI!

}
}

// Keeping for backward compatibility

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually need this right?

assistantId,
threadId: threadId ?? null,
onCustomEvent: (event, options) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is removed because you don't need genui for this app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants