Skip to content

Modernization for Generic LaTeX tables formatter using Pandas and Jinja2 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

d3centQ
Copy link

@d3centQ d3centQ commented Feb 1, 2025

Added a conditional block for multi-level/single-level headers to avoid out-of-range or undefined variables.
Removed reliance on the deprecated Index.format(sparsify=...).
Replaced applymap with column-wise apply + map for future-proofing.
Updated numeric parsing to use errors='coerce' for more robust handling of invalid data.
These changes ensure better compatibility with newer pandas versions, provide clearer error

@lahwaacz
Copy link
Owner

lahwaacz commented Feb 4, 2025

Please remove all files under .idea, they should not be part of the git project. You can add the directory to the .gitignore file instead.

@d3centQ
Copy link
Author

d3centQ commented Feb 5, 2025

Removed the .idea directory from Git tracking and added it to the .gitignore file

@lahwaacz
Copy link
Owner

lahwaacz commented Feb 5, 2025

There are still 6 files remaining according to the Files changed tab

@d3centQ
Copy link
Author

d3centQ commented Feb 5, 2025

those 6 files should be removed now

@lahwaacz
Copy link
Owner

There are still some files under .idea/ on the Files changed tab.

Also please try to resolve the conflicts that GitHub now shows.

@d3centQ
Copy link
Author

d3centQ commented Feb 12, 2025

I resolved the conflicts

.gitignore Outdated
/build/
/dist/
*.egg-info/
.venv/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a line with .idea/ here and remove the .idea/.gitignore file.

@lahwaacz
Copy link
Owner

The make_examples.py script needs to be re-run and changes in the examples directory committed.

Then note that there are currently 22 commits in this pull request: https://github.com/lahwaacz/PyLaTeXtables/pull/2/commits
Please do a git rebase and squash all commits that have the same message together. For example, the two commits with "resolving gitignore" message should be squashed into one commit, etc.

@d3centQ
Copy link
Author

d3centQ commented Feb 13, 2025

I cannot squash my commits because I see all commits were made ,and I cant merge it

@lahwaacz
Copy link
Owner

Hmm ok, it might be easier to start over 😅 Can you create a new branch and add the line with .idea/ to the main .gitignore` file? Then you might e.g. use the black formatter to reformat the code.

d3centQ pushed a commit to d3centQ/PyLaTeXtables that referenced this pull request Feb 22, 2025
# This is the 1st commit message:

Add __pycache__ files

# This is the commit message lahwaacz#2:

Handled multi-level headers, removed sparsify calls, replaced applymap, coerced numerics.

Handled multi-level headers, removed sparsify calls, replaced applymap, coerced numerics.

Handled multi-level headers, removed sparsify calls, replaced applymap, coerced numerics.

Handled multi-level headers, removed sparsify calls, replaced applymap, coerced numerics.

Handled multi-level headers, removed sparsify calls, replaced applymap, coerced numerics.

Handled multi-level headers, removed sparsify calls, replaced applymap, coerced numerics.

Handled multi-level headers, removed sparsify calls, replaced applymap, coerced numerics.

Handled multi-level headers, removed sparsify calls, replaced applymap, coerced numerics.

Remove .idea files from tracking

fixing gitignore file

fixing gitignore file

fixing gitignore file

fixing gitignore file

fixing gitignore file

fixing formatting

fixing formatting

fixing formatting

fixing eoc.tex

fixing makeexample.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants