Skip to content

Build(deps): Bump github.com/docker/cli from 27.5.1+incompatible to 28.1.1+incompatible #20646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 21, 2025

Bumps github.com/docker/cli from 27.5.1+incompatible to 28.1.1+incompatible.

Commits
  • 4eba377 Merge pull request #6025 from thaJeztah/bump_compose
  • 9cd3557 Dockerfile: update compose to v2.35.1
  • cf87480 Merge pull request #6020 from thaJeztah/bump_engine_28.1
  • adb0d29 vendor: github.com/docker/docker v28.1.0
  • 4d8c241 Merge pull request #6018 from thaJeztah/use_api_socket_no_empty
  • 711fcae cli/command/container: --use-api-socket: don't write empty credentials
  • ed694db Merge pull request #5868 from thaJeztah/bump_go_version
  • 79ab3cb Merge pull request #6017 from thaJeztah/bump_engine_28.1
  • 1d768f8 update go:build tags to go1.23 to align with vendor.mod
  • 0e75283 Merge pull request #6016 from thaJeztah/context_completion
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/docker/cli](https://github.com/docker/cli) from 27.5.1+incompatible to 28.1.1+incompatible.
- [Commits](docker/cli@v27.5.1...v28.1.1)

---
updated-dependencies:
- dependency-name: github.com/docker/cli
  dependency-version: 28.1.1+incompatible
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Apr 21, 2025
@dependabot dependabot bot requested review from medyagh and prezha April 21, 2025 18:51
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dependabot dependabot bot requested a review from spowelljr April 21, 2025 18:51
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 21, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 21, 2025
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@medyagh
Copy link
Member

medyagh commented Apr 24, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2025
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20646) |
+----------------+----------+---------------------+
| minikube start | 52.7s    | 52.1s               |
| enable ingress | 17.0s    | 17.6s               |
+----------------+----------+---------------------+

Times for minikube start: 53.2s 52.3s 52.7s 51.2s 54.0s
Times for minikube (PR 20646) start: 51.5s 51.1s 54.1s 51.1s 52.8s

Times for minikube ingress: 17.1s 20.6s 15.1s 15.2s 17.1s
Times for minikube (PR 20646) ingress: 16.2s 15.1s 19.7s 18.6s 18.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20646) |
+----------------+----------+---------------------+
| minikube start | 23.6s    | 24.3s               |
| enable ingress | 12.6s    | 12.2s               |
+----------------+----------+---------------------+

Times for minikube start: 25.1s 24.2s 22.3s 21.9s 24.7s
Times for minikube (PR 20646) start: 25.3s 24.4s 22.2s 24.8s 24.8s

Times for minikube ingress: 12.4s 12.3s 12.4s 12.8s 13.3s
Times for minikube (PR 20646) ingress: 12.4s 12.3s 11.4s 12.4s 12.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20646) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.5s               |
| enable ingress | 31.2s    | 34.8s               |
+----------------+----------+---------------------+

Times for minikube (PR 20646) start: 20.3s 23.7s 21.2s 21.8s 20.5s
Times for minikube start: 20.4s 20.7s 23.9s 21.4s 21.7s

Times for minikube ingress: 38.9s 27.8s 22.8s 38.8s 27.8s
Times for minikube (PR 20646) ingress: 38.8s 34.8s 22.8s 38.8s 38.8s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. dependencies Pull requests that update a dependency file go Pull requests that update Go code ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants