Added compiling target Android support #982
Open
+136
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created `pthread/btrfs_pthread.h` and `pthread/btrfs_pthread.c` to allow Android and bionic libc emulating `pthread_setcanceltype`, `pthread_setcancelstate`, `pthread_cancel` and some other definitions. Since Android NDK does not support `pthread_cancel()`, this workaround method uses `pthread_kill()` instead. Signed-off-by: Shadichy <[email protected]>
This patch is from termux/termux-packages Signed-off-by: Shadichy <[email protected]>
…rgeting Android Android NDK does not support `qsort_r`, this workaround first add a list of `id` to struct `compare`, and then reverse the list, and finally do the sorting stuffs using `qsort`. This helps preserve the sorting order without `qsort_r` Signed-off-by: Shadichy <[email protected]>
kdave
force-pushed
the
devel
branch
6 times, most recently
from
ef43ce6 to
3eff852
Compare
|
Thanks, this will need to be reworked so there are no standalone ifdefs just for android. Compatibility wrappers should be hidden in files, detected at build time and the implementation switched by some ifdef. I'll apply the patches without changes as this is what you've probably tested and do the updates myself. As this will become supported config, we'll need github actions for that too. |
|
The |
kdave
reviewed
May 30, 2025
| pthread_cancel; /* used */ | ||
| local: | ||
| *; | ||
| }; |
There was a problem hiding this comment.
Why is this needed? The file is not used anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.