Fix progress reporting for files larger than Integer.MAX_VALUE (2.14 GB) on Android #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Feat]Update iOS Implementation with unused Android methods
[Feat] Android Implementation for New Arch
[Feat] Connect iOS to JS and test TM
[Feat] Update iOS implementation - 3/n
[Chore] Remove Apps from examples folder - 2/n
[FEAT] Add Flow specs - New Arch Migration 1/n
…ackage Fix bug issue #113 in new version package(0.16.3)
Seems like this is just an example of the "rename everything" commit renaming a little more than it should. It does not seem to be a repo on https://github.com/RonRadtke/react-native-blob-util-dev either.
'boolean java.lang.String.isEmpty()' on a null object reference on certain Android phones.
Fix download issue with file size 2GB+
…/react-native-blob-util into user/anuverma/windows
Add Support for Windows New Arch Thank you very much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you attempt to download a file that is larger than ~2 GB on Android you won't receive any progress updates. The fix in this case is simply hard coding a max contentLength so that at least delta updates will come through. This was confirmed to work experimentally and is admittedly a small edge case.