Update support for Python 2.6+ #178
Conversation
|
LGTM @joestump |
|
Is 2.5 even supportable? Travis doesn't run it so it'll never be ci tested. I thought the new |
|
I agree with @hayd. Honestly we should probably discuss a 2.6 EOL at some point in the next 12-18 months. I say we go 2.6+ |
|
I hadn't realised that. I agree also... |
|
I confirmed that tests currently pass under 2.5, but you have to install an old version of mock to run them. I'm not particularly persuaded to drop a version because of the CI used, but the exception syntax makes it really difficult to move forward. So altogether, I support dropping 2.5 as well. I'll update this PR. |
rickhanlonii
changed the title
|
This PR now updates README to 2.6+, removes pre-2.6 library imports, and uses 2.6+ style exception syntax. @jaitaiwan @joestump this can go. I'm going to work on getting the 3.3 and 3.4 tests to pass. |
|
There's going to be many merge conflicts in resolving these (e.g. the exception as syntax). We should fix up/merge #142 first. |
|
I concur with @hayd. We should get PT3K merged in first. Also @jaitaiwan you should release what we have in master if you're comfortable as 1.9-RC1 IMO. |
|
Ok, @rickhanlonii are you happy for current master to be 1.9-RC1? |
|
Yeah I'm good with that. |
jaitaiwan
force-pushed
the
develop
branch
2 times, most recently
from
a660e24 to
ea42271
Compare
|
@rickhanlonii probably need this updated since we've released 1.9 |
|
This is no longer relevant. README.md was already updated with the correct versions and syntax has been updated. |
| @@ -460,7 +449,7 @@ def get_normalized_parameters(self): | |||
| else: | |||
| try: | |||
| value = list(value) | |||
| except TypeError, e: | |||
| except TypeError as e: | |||
| assert 'is not iterable' in str(e) | |||
| items.append((to_utf8_if_string(key), to_utf8_if_string(value))) | |||
There was a problem hiding this comment.
- E501 line too long (114 > 79 characters)
As discussed here, there's a discussion to drop support for Python 2.4.
This pull takes the first step by updating the README, removing pre-2.6 library imports, and 2.6+ style exception syntax.
Moved #177 to develop branch here.