Skip to content

Add tests & bugfix resulting from it #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add tests & bugfix resulting from it #1

wants to merge 9 commits into from

Conversation

jfversluis
Copy link
Owner

No description provided.

@dsharkou
Copy link

Hi, Gerald!
Any progress on it to have Release version?

@jfversluis jfversluis marked this pull request as ready for review April 18, 2025 21:43
@jfversluis jfversluis requested a review from Copilot April 18, 2025 21:43
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the MessagingCenter implementation to use a custom weak-referenced subscription mechanism and adds tests to verify the changes. It also updates the CI workflows to run these tests during build and release.

Reviewed Changes

Copilot reviewed 7 out of 11 changed files in this pull request and generated 1 comment.

File Description
src/Plugin.Maui.MessagingCenter/MessagingCenterAdapter.cs Introduces an adapter that forwards calls to the static API.
src/Plugin.Maui.MessagingCenter/MessagingCenter.shared.cs Refactors the MessagingCenter implementation and removes legacy messaging classes.
src/Plugin.Maui.MessagingCenter/IMessagingCenter.cs Updates the interface documentation and signatures.
.github/workflows/release-nuget.yml & .github/workflows/ci.yml Adds steps to run tests, improving validation in CI and release.
Files not reviewed (4)
  • samples/Plugin.Maui.MessagingCenter.Sample.sln: Language not supported
  • samples/Plugin.Maui.MessagingCenter.Sample/Plugin.Maui.MessagingCenter.Sample.csproj: Language not supported
  • src/Plugin.Maui.MessagingCenter/Plugin.Maui.MessagingCenter.csproj: Language not supported
  • tests/Plugin.Maui.MessagingCenter.UnitTests.csproj: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants