Add tests & bugfix resulting from it #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Gerald! |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the MessagingCenter implementation to use a custom weak-referenced subscription mechanism and adds tests to verify the changes. It also updates the CI workflows to run these tests during build and release.
Reviewed Changes
Copilot reviewed 7 out of 11 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Plugin.Maui.MessagingCenter/MessagingCenterAdapter.cs | Introduces an adapter that forwards calls to the static API. |
| src/Plugin.Maui.MessagingCenter/MessagingCenter.shared.cs | Refactors the MessagingCenter implementation and removes legacy messaging classes. |
| src/Plugin.Maui.MessagingCenter/IMessagingCenter.cs | Updates the interface documentation and signatures. |
| .github/workflows/release-nuget.yml & .github/workflows/ci.yml | Adds steps to run tests, improving validation in CI and release. |
Files not reviewed (4)
- samples/Plugin.Maui.MessagingCenter.Sample.sln: Language not supported
- samples/Plugin.Maui.MessagingCenter.Sample/Plugin.Maui.MessagingCenter.Sample.csproj: Language not supported
- src/Plugin.Maui.MessagingCenter/Plugin.Maui.MessagingCenter.csproj: Language not supported
- tests/Plugin.Maui.MessagingCenter.UnitTests.csproj: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.