Extension/balance of plant #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbeauf
requested review from
DavidPCoster,
simpla-fusion,
aksinghh,
SimonPinches,
yegakjh,
medvedevsyu,
pankin and
olivhoenen
as code owners
| </xs:element> | ||
| <xs:element name="power_electric_generated"> | ||
| <xs:annotation> | ||
| <xs:documentation>The net electric power produced by the thermal plant, equal tot the power produced by turbines LESS the power consumed by pumps and compressors</xs:documentation> |
There was a problem hiding this comment.
Typo and minor chnages
Suggested change
| <xs:documentation>The net electric power produced by the thermal plant, equal tot the power produced by turbines LESS the power consumed by pumps and compressors</xs:documentation> | |
| <xs:documentation>Net electric power produced by thermal plant, equal to power produced by turbines LESS power consumed by pumps and compressors</xs:documentation> |
| </xs:complexType> | ||
| <xs:complexType name="bop_power_electric_system"> | ||
| <xs:annotation> | ||
| <xs:documentation>System involed in the electric power plant operation</xs:documentation> |
There was a problem hiding this comment.
Typo:
Suggested change
| <xs:documentation>System involed in the electric power plant operation</xs:documentation> | |
| <xs:documentation>System involved in electric power plant operation</xs:documentation> |
| </xs:element> | ||
| <xs:element name="system" type="bop_power_electric_system" maxOccurs="10"> | ||
| <xs:annotation> | ||
| <xs:documentation>Set of systems involved in the electric plant operation</xs:documentation> |
There was a problem hiding this comment.
Two spaces
Suggested change
| <xs:documentation>Set of systems involved in the electric plant operation</xs:documentation> | |
| <xs:documentation>Set of systems involved in the electric plant operation</xs:documentation> |
| </xs:complexType> | ||
| <xs:element name="balance_of_plant"> | ||
| <xs:annotation> | ||
| <xs:documentation>Electricial and thermal power balance of the plant</xs:documentation> |
There was a problem hiding this comment.
Typo
Suggested change
| <xs:documentation>Electricial and thermal power balance of the plant</xs:documentation> | |
| <xs:documentation>Electrical and thermal power balance of the plant</xs:documentation> |
| </xs:element> | ||
| <xs:element name="thermal_efficiency_cycle"> | ||
| <xs:annotation> | ||
| <xs:documentation>The fractional thermal effiency of the power cycle. Calculated as 1-Q_out/Q_in</xs:documentation> |
There was a problem hiding this comment.
Add some spacing in formula:
Suggested change
| <xs:documentation>The fractional thermal effiency of the power cycle. Calculated as 1-Q_out/Q_in</xs:documentation> | |
| <xs:documentation>The fractional thermal effiency of the power cycle. Calculated as 1 - Q_out/Q_in</xs:documentation> |
| </xs:element> | ||
| <xs:element name="thermal_efficiency_plant"> | ||
| <xs:annotation> | ||
| <xs:documentation>The fractional thermal effiency of the entire BOP thermal plant, inlcudes all of the individual cycles. Calculated as 1-Q_out/Q_in</xs:documentation> |
There was a problem hiding this comment.
Suggested change
| <xs:documentation>The fractional thermal effiency of the entire BOP thermal plant, inlcudes all of the individual cycles. Calculated as 1-Q_out/Q_in</xs:documentation> | |
| <xs:documentation>The fractional thermal effiency of the entire BOP thermal plant, inlcudes all of the individual cycles. Calculated as 1 - Q_out/Q_in</xs:documentation> |
| @@ -0,0 +1,554 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="yes"?> | |||
| <?modxslt-stylesheet type="text/xsl" media="fuffa, screen and $GET[stylesheet]" href="./%24GET%5Bstylesheet%5D" alternate="no" title="Translation using provided stylesheet" charset="UTF-8" ?> | |||
DavidPCoster
approved these changes
Apr 10, 2025
simpla-fusion
approved these changes
Apr 10, 2025
medvedevsyu
approved these changes
Apr 13, 2025
pankin
approved these changes
Apr 22, 2025
aksinghh
approved these changes
Apr 29, 2025
yegakjh
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new IDSs needed by system codes
balance_of_plant_flat.zip