Applies semantic_tags to ground #2410
Open
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YunLiu <[email protected]>
kellyguo11
changed the title
|
Thanks a lot for the fix! Could you please also update the CHANGELOG and extension.toml files to include a note on the change and the reason behind it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The check here: the RigidBodyMaterialCfg used by GroundPlaneCfg lacks a semantic_tags attribute. So the semantic_tags will not set to the ground correctly, then the semantic_segmentation_mapping can not been correctly mapped.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Ground didn't been mapping correctly.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there