Skip to content

chore: run build-windows-x86 on windows-2022 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Jun 9, 2025

@achingbrain Can we run build-windows-x86 on windows-2022? windows-2019 are being deprecated this month (see actions/runner-images#12045). The machines running windows-2019 were x64 machines so I don't think we were running that job on them for the matching architecture, but do you know if there's any other features from Windows Server 2019 that we need?

@galargh galargh requested a review from achingbrain June 9, 2025 16:15
Copy link
Collaborator

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, we don’t use any server-specific features so any recent Windows will do

@galargh galargh merged commit 3e509c9 into master Jun 10, 2025
1 check passed
@galargh galargh deleted the windows-2019-deprecation branch June 10, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants