Input UI normalization #1496
Merged
Input UI normalization #1496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjsjohnmurray
previously approved these changes
Mar 5, 2025
There was a problem hiding this comment.
Changes look fine.
We're likely overusing ignoreFocusOut, but at least some of the instances could have good justification so I don't think we should do a blanket removal. The question to put is: Might the user want to check information elsewhere on their screen while deciding which option(s) to pick?
gjsjohnmurray
approved these changes
Mar 5, 2025
This was referenced Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
titleinstead ofplaceHolderfor inputs that only have one promptI deliberately didn't do anything about
ignoreFocusOutbecause I wanted to get your feedback first. Should we remove this from our extensions so there's always a mouse option to dismiss an input? Once this PR is merged I will make similar changes to the other two extensions.