Add command for opening InterSystems documents #1398
Conversation
|
@isc-rsingh @gjsjohnmurray How do you feel about using a chord ask the keybinding for this? |
|
How about |
|
That's taken on Windows |
|
Ugh. Now I see the semantics are different on Windows and Mac. On Mac, Cmd+O does both the open file and open folder semantics. While on Windows there are 2 separate keybindings, Ctrl+O for open file and the chord |
|
I think |
|
My suggestion was based on the convenience of not lifting the finger off of |
|
That's a good point. Let's see what John thinks. |
|
Adding keybindings to new versions of existing extensions brings the risk that some current users will experience problems because the combo we choose clashes with another extension or a keybinding they set up. I'd be inclined not to set one. |
|
I'm fine with not setting one |
|
If you're both happy with this I'll merge it |
|
I shan't have time to review / try this before tomorrow, so go ahead if you want. |
|
No problem John, I'll wait for you review |
|
How about adding the command to the Explorer view title menu, perhaps with |
|
Mapped .inc documents are not being hidden. To reproduce this, be connected to a namespace such as USER, set toggles to show system documents and to hide mapped ones. Observe that some %-packages still get listed. Drill into one and discover that you are being offered .inc documents despite them being mapped here from another database. |
|
It would be nice if the three toggle buttons remembered their state between invocations of the selector, at least for the duration of my session, and perhaps persist per workspace. It would also be nice if I could see the state of each. AFAIK the only way of doing this at the moment might be to create 6 of our own icons, 3 to represent "on" and 3 "off", then manipulate the Alternatively I could have a go at a PR for microsoft/vscode#185356, or better still my suggestion at microsoft/vscode#221397 (comment) gets accepted. |
You mean the default File Explorer, right? I will see if I can add the command there.
This sounds like a bug in the
I completely agree; this is why I opened that issue a while ago. I think your suggestion or the colored buttons would both be good solutions to this problem. |
Yes. Another bit of feedback:
Could the title be reworded "Open a document in ..."? |
|
@gjsjohnmurray I have that clumsy language to allow for the API caller to change the suffix but since we have no other callers now I can change that |
|
@gjsjohnmurray I wasn't able to add the command inline using an icon, but it does appear in the |
|
Did you try adding |
|
That worked! I tried |
Logged in WRC as 989244 |
|
On a multiroot isfs workspace could the "Select workspace folder" selector default to the folder of the current active document rather thann the first folder? |
|
The |
I agree it's not worth the effort of doing that. |
|
Thanks for all the feedback. I think this is ready to go. If/when we get toggle buttons or colored buttons for |
Confirmed by WRC, and Jira DP-433169 opened. |
Fixed by MAK5922 (Do not display routines from IRISLIB/IRISSYS when 'mapped=0' parameter for StudioOpenDialog query) which may appear in 2024.3 |
This PR fixes #1379. The new
Open InterSystems Document...command can be opened from the command palette and it provides a UI for browsing all files in the connected server-namespace. The user can either pick an item in the list, or type text into the filter box and press "Enter" to submit that. The UI should function very similarity to the built-in simple file dialog. I would like to assign a keybinding to this command, but I couldn't find a good one so I'm open to suggestions.