Skip to content

Fix Import Local Files... command #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2024
Merged

Fix Import Local Files... command #1396

merged 1 commit into from
Jul 5, 2024

Conversation

isc-bsaviano
Copy link
Contributor

  • Fixes a bug where file bytes couldn't be converted to text due to an undefined instantiated variable
  • Allows importing over a deployed class, which is consistent with the XML import command, and SMP, terminal, and Studio imports

gjsjohnmurray
gjsjohnmurray approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on code review

@isc-bsaviano isc-bsaviano merged commit 43724cd into intersystems-community:master Jul 5, 2024
5 checks passed
@isc-bsaviano isc-bsaviano deleted the import-local-files branch July 5, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isc-rsingh isc-rsingh isc-rsingh approved these changes

@gjsjohnmurray gjsjohnmurray gjsjohnmurray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isc-bsaviano @isc-rsingh @gjsjohnmurray