Skip to content

Update CI #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Conversation

isc-bsaviano
Copy link
Contributor

No description provided.

@isc-bsaviano
Copy link
Contributor Author

Do we really need to build on all three platforms? Action coactions/setup-xvfb@v1 hasn't been updated to Node 20, but xvfb is already installed in the latest Ubuntu runners. Also, The Windows build started failing and updating the actions didn't help.

@isc-rsingh
Copy link
Member

I haven't looked into what these checks do, but running successfully on Mac and Windows is key -- and marginally Ubuntu (as a proxy for all Linuxes). Are you saying running these checks on all these platforms aren't helping us ensure that?

@isc-bsaviano
Copy link
Contributor Author

Yes, exactly. This extension is pure JavaScript and therefore is platform independent. Testing on one OS (Ubuntu) is good enough.

@gjsjohnmurray
Copy link
Contributor

@daimor ought to know, but I guess one reason for running the CI on the different platforms is so that the tests happen on them. But seeing as no actual tests have been written yet we're unlikely to be losing anything by reducing the CI to a single platform.

@isc-bsaviano
Copy link
Contributor Author

Yeah, that's probably the reason Dmitry implemented the CI the way he did.

@isc-bsaviano
Copy link
Contributor Author

I updated the build CI to only run on Ubuntu. It succeeded, and there are no more deprecation warnings.

@isc-bsaviano isc-bsaviano merged commit bf5ede1 into intersystems-community:master Apr 22, 2024
5 checks passed
@isc-bsaviano isc-bsaviano deleted the update-ci branch April 22, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants