-
Notifications
You must be signed in to change notification settings - Fork 48
Update CI #1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI #1352
Conversation
Do we really need to build on all three platforms? Action |
I haven't looked into what these checks do, but running successfully on Mac and Windows is key -- and marginally Ubuntu (as a proxy for all Linuxes). Are you saying running these checks on all these platforms aren't helping us ensure that? |
Yes, exactly. This extension is pure JavaScript and therefore is platform independent. Testing on one OS (Ubuntu) is good enough. |
@daimor ought to know, but I guess one reason for running the CI on the different platforms is so that the tests happen on them. But seeing as no actual tests have been written yet we're unlikely to be losing anything by reducing the CI to a single platform. |
Yeah, that's probably the reason Dmitry implemented the CI the way he did. |
I updated the build CI to only run on Ubuntu. It succeeded, and there are no more deprecation warnings. |
No description provided.