Skip to content

Remove objectscript.ignoreInstallServerManager setting #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2024
Merged

Remove objectscript.ignoreInstallServerManager setting #1339

merged 2 commits into from
Mar 28, 2024

Conversation

isc-bsaviano
Copy link
Contributor

This setting is no longer required because this extension depends on the Server Manager in its package.json

gjsjohnmurray
gjsjohnmurray reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you are also getting rid of the ignoreInstallLanguageServer setting.

Also, is any of the Server Manager install logic still needed, given the dependency?

@isc-bsaviano
Copy link
Contributor Author

You're right, none of that is necessary! I'll remove it. The ignoreInstallLanguageServer setting is undocumented so I figured it was safe to remove. However, I think I should keep it. There are a few platforms that the Language Server doesn't support.

gjsjohnmurray
gjsjohnmurray approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isc-bsaviano isc-bsaviano merged commit 2b84f09 into intersystems-community:master Mar 28, 2024
7 checks passed
@isc-bsaviano isc-bsaviano deleted the remove-setting branch March 28, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isc-rsingh isc-rsingh isc-rsingh approved these changes

@gjsjohnmurray gjsjohnmurray gjsjohnmurray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isc-bsaviano @isc-rsingh @gjsjohnmurray