WIP: Implement validator for CBOR #68
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
reviewed
Apr 11, 2025
| validateGroup cddl (NE.toList tss) newRules | ||
| (t NE.:| ts, _) -> | ||
| doValidate cddl t rule | ||
| *> (maybe (pure ()) (\ne -> validateItem cddl ne rule) $ NE.nonEmpty ts) |
There was a problem hiding this comment.
Seems like a common patter. Would probably be useful to create a helper for it
| @@ -70,6 +71,8 @@ library | |||
| , data-default-class | |||
| , foldable1-classes-compat | |||
| , generic-optics | |||
| , lens | |||
There was a problem hiding this comment.
We avoid lens, since it's dependency footprint is enormous
Suggested change
| , lens | |
| , microlens |
jasagredo
force-pushed
the
js/numeric-data
branch
2 times, most recently
from
c277099 to
f58e83d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.