Skip to content

Move SERVER_URL to a nextjs runtime config. #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −1
Open

Move SERVER_URL to a nextjs runtime config. #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e7edb0
Move SERVER_URL to a nextjs runtime config.
julionav Sep 20, 2024
a14d788
Merge branch 'main' into feature/runtime-server-url-config
MikeShi42 Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/app/next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ module.exports = withNextra({
swcMinify: false,
publicRuntimeConfig: {
version,
serverUrl: process.env.NEXT_PUBLIC_SERVER_URL
},
productionBrowserSourceMaps: false,
...(process.env.NEXT_OUTPUT_STANDALONE === 'true'
Expand Down
7 changes: 6 additions & 1 deletion packages/app/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import getConfig from 'next/config';

const runtimeConfig = getConfig().publicRuntimeConfig;
export const SERVER_URL =
process.env.NEXT_PUBLIC_SERVER_URL || 'http://localhost:8000'; // NEXT_PUBLIC_SERVER_URL can be empty string
runtimeConfig.serverUrl ||
process.env.NEXT_PUBLIC_SERVER_URL ||
'http://localhost:8000'; // NEXT_PUBLIC_SERVER_URL can be empty string

export const HDX_API_KEY = process.env.HYPERDX_API_KEY as string; // for nextjs server
export const HDX_SERVICE_NAME =
Expand Down
Loading