Skip to content

Ci/image stream #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Ci/image stream #2244

wants to merge 12 commits into from

Conversation

deantchi
Copy link
Contributor

@deantchi deantchi commented Mar 17, 2025

Add steps to also build/push into Google Artifact Registry using environments in a Matrix strategy. Test build can be viewed here.

Copy link

github-actions bot commented Mar 17, 2025

Vercel deployment URL: https://stacks-blockchain-paw5jxkg9-hirosystems.vercel.app 🚀

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@deantchi deantchi marked this pull request as draft March 18, 2025 14:11
@deantchi
Copy link
Contributor Author

Moved the GAR replication into a separate step to prevent the Docker push step from running three times due to the matrix.

@deantchi deantchi marked this pull request as ready for review March 18, 2025 14:55
@deantchi deantchi requested a review from CharlieC3 March 18, 2025 14:55
Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one minor change.

Once we introduce CD to this workflow, we'll be able to change the gar upload to an environment only once the env's release gate is opened.

@@ -14,6 +14,8 @@ on:
- "**/package.json"
pull_request:
workflow_dispatch:
env:
GIT_BRANCH: ${{ github.ref_name }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is available by default in the GITHUB_REF_NAME env var.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants