-
Notifications
You must be signed in to change notification settings - Fork 123
Ci/image stream #2244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci/image stream #2244
Conversation
Vercel deployment URL: https://stacks-blockchain-paw5jxkg9-hirosystems.vercel.app 🚀 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Moved the GAR replication into a separate step to prevent the Docker push step from running three times due to the matrix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one minor change.
Once we introduce CD to this workflow, we'll be able to change the gar upload to an environment only once the env's release gate is opened.
@@ -14,6 +14,8 @@ on: | |||
- "**/package.json" | |||
pull_request: | |||
workflow_dispatch: | |||
env: | |||
GIT_BRANCH: ${{ github.ref_name }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is available by default in the GITHUB_REF_NAME
env var.
Add steps to also build/push into Google Artifact Registry using
environments
in a Matrix strategy. Test build can be viewed here.