Skip to content

fix: convert to esm #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: convert to esm #196

wants to merge 3 commits into from

Conversation

eablack
Copy link
Contributor

@eablack eablack commented May 29, 2025

W-18293857

Description

This moves heroku-cli/command to esm, in line with the forthcoming v11 of the cli. The commonjs version of this was causing problems when being consumed by the cli.

Testing

There are several example commands in /examples that can be used to test that things work. They are invoked via:

  1. pull down this branch and npm install
  2. npm run example whoami

@eablack eablack marked this pull request as ready for review June 2, 2025 21:36
@eablack eablack requested a review from a team as a code owner June 2, 2025 21:36
Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants