Batch2 Remove Paging Iterator #6783
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Formatting check succeeded! |
Capt-Mac
changed the title
...r-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/8_2_0/6784-remove-batch2-paginator.yaml
Show resolved
Hide resolved
hapi-fhir-storage-batch2/src/main/java/ca/uhn/fhir/batch2/maintenance/JobInstanceProcessor.java
Outdated
Show resolved
Hide resolved
hapi-fhir-storage-batch2/src/main/java/ca/uhn/fhir/batch2/maintenance/JobInstanceProcessor.java
Outdated
Show resolved
Hide resolved
hapi-fhir-storage-batch2/src/main/java/ca/uhn/fhir/batch2/maintenance/JobInstanceProcessor.java
Show resolved
Hide resolved
hapi-fhir-storage-batch2/src/main/java/ca/uhn/fhir/batch2/maintenance/JobInstanceProcessor.java
Outdated
Show resolved
Hide resolved
lukedegruchy
approved these changes
Mar 10, 2025
Capt-Mac
requested review from
michaelabuckley,
jamesagnew and
tadgh
as code owners
michaelabuckley
approved these changes
Mar 10, 2025
| counter++; | ||
| } | ||
| } | ||
| // catch to prevent unlimited looping |
There was a problem hiding this comment.
trivial: This counting and check probably isn't required since you do the empty check above. The next page after a short result will be empty.
jamesagnew
reviewed
Mar 11, 2025
hapi-fhir-storage-batch2/src/main/java/ca/uhn/fhir/batch2/maintenance/JobInstanceProcessor.java
Outdated
Show resolved
Hide resolved
jamesagnew
reviewed
Mar 11, 2025
hapi-fhir-storage-batch2/src/main/java/ca/uhn/fhir/batch2/maintenance/JobInstanceProcessor.java
Show resolved
Hide resolved
…tenance/JobInstanceProcessor.java Co-authored-by: James Agnew <[email protected]>
…api-fhir into batch2-remove-paging-iterator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6784
eliminate use of PagingIterator and find an alternative approach to queue workchunks without bloating memory or under utilizing available processors