Skip to content

Fix response_body #5510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ndtretyak
Copy link

References to other Issues or PRs

Have you read the Contributing Guidelines?

Yes

Brief description of what is fixed or changed

#4622 replaced proto.Message with a concrete response type in response_* structs and removed the line that cast proto.Message, since it seemed that we could now access m's fields directly
https://github.com/grpc-ecosystem/grpc-gateway/pull/4622/files#diff-9648d8792ce733c8bbce0d613a620fffdb73cff98a91763507a1984eb520d5feL766

However, if the response type has a field with the same name (e.g., type Response struct {Response string}) it does not work as expected.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, nice find! Thank you.

@johanbrandhorst
Copy link
Collaborator

Looks like we need to regenerate some bazel files, you can see the steps in CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants