fix: describe behaviour for onValidate maskError (see discussion question) #3899
Conversation
|
| const onValidatePlugin: Plugin = { | ||
| onValidate({ setResult }) { | ||
| setResult([ | ||
| createGraphQLError('UNMASKED ERROR', { extensions: { code: 'VALIDATION_ERROR' } }), |
There was a problem hiding this comment.
GraphQLError instances are not masked. The errors are masked only if it is an error is not an instance of GraphQLError.
And the result of validate function is GraphQLError[] so it is expected to return an array of GraphQLError. Yoga doesn't expect validate to return non GraphQL errors so they are not sent to maskError function. So running an extra maskError for validation errors are unnecesary.
There was a problem hiding this comment.
Thanks @ardatan! We realize that the default maskError function does not act on GraphQLErrors at all, but we want to mask GraphQLErrors as well.
However, even if we write a custom maskError function, it is not triggered at all for GraphQLErrors.
Would it be better to use onResultProcess to update the result with the masked error?
There was a problem hiding this comment.
Yes!, You can use onResultProcess to modify the final response, or you can basically use onValidateDone if you want to modify validation errors specifically.
aryascripts
changed the title
See discussion question for the description: #3900