Skip to content

feat: add tap sender aggregator endpoints to default config #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sahra-karakoc
Copy link
Member

Adds E&N and GraphOps Gateway tapp aggregator endpoints to default values of the tap config

@sahra-karakoc sahra-karakoc force-pushed the sahra/add-tap-sender-defaults branch from 2be7744 to c43772b Compare May 29, 2025 11:18
@suchapalaver
Copy link
Collaborator

Adds E&N and GraphOps Gateway tapp aggregator endpoints to default values of the tap config

Hi @sahra-karakoc thanks for this! Looks like a test needs to be updated as well.

@sahra-karakoc sahra-karakoc force-pushed the sahra/add-tap-sender-defaults branch from c43772b to ded989c Compare May 29, 2025 12:05
@sahra-karakoc
Copy link
Member Author

@suchapalaver updated!

@coveralls
Copy link

coveralls commented May 29, 2025

Pull Request Test Coverage Report for Build 15325626066

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 72.359%

Files with Coverage Reduction New Missed Lines %
crates/watcher/src/lib.rs 4 92.71%
Totals Coverage Status
Change from base Build 15302134728: -0.03%
Covered Lines: 8809
Relevant Lines: 12174

💛 - Coveralls

@suchapalaver
Copy link
Collaborator

@suchapalaver updated!

Thank you! Approved! We just need you to signoff on your commits, please @sahra-karakoc!

@sahra-karakoc sahra-karakoc force-pushed the sahra/add-tap-sender-defaults branch from ded989c to 0469b92 Compare May 29, 2025 14:01
@suchapalaver
Copy link
Collaborator

For some reason the signature is still showing as unverified @sahra-karakoc

@sahra-karakoc
Copy link
Member Author

@suchapalaver it should be solved now!

@suchapalaver suchapalaver merged commit afc50dc into graphprotocol:main May 29, 2025
11 checks passed
@github-actions github-actions bot mentioned this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants