-
Notifications
You must be signed in to change notification settings - Fork 15
fix: generate manifest in conformance with the deployment spec #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes update the Changes
Sequence Diagram(s)sequenceDiagram
participant Helm Chart
participant Kubernetes API
Helm Chart->>Kubernetes API: Deploy resource
alt If kind == StatefulSet
Helm Chart->>Kubernetes API: Include serviceName in spec
else Other kinds
Helm Chart->>Kubernetes API: Do not include serviceName in spec
end
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
charts/graph-node/Chart.yaml (1)
25-25
: Chart appVersion updated correctly; consider bumping chart version
TheappVersion
has been bumped fromv0.38.0
tov0.39.0
, which aligns with the new Graph Node release. Per Helm SemVer best practices, please also increment the chart’sversion
(currently0.5.9
) to0.5.10
to reflect this change in the chart artifacts.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (3)
charts/graph-node/Chart.yaml
(1 hunks)charts/graph-node/README.md
(1 hunks)charts/graph-node/templates/graph-node/all.yaml
(1 hunks)
🔇 Additional comments (2)
charts/graph-node/README.md (1)
5-5
: Update version badge for AppVersion
The README badge forAppVersion
has been updated tov0.39.0
, keeping it in sync withChart.yaml
.charts/graph-node/templates/graph-node/all.yaml (1)
65-74
: Conditionally include serviceName only for StatefulSet
TheserviceName
(and accompanying StatefulSet properties) has been moved inside theif (eq $values.kind "StatefulSet")
block to prevent schema non-conformance for other kinds (e.g.,Deployment
). Verify that indentation underspec:
remains correct and that rendering withhelm template
orhelm lint
succeeds for both resource kinds.
Summary by CodeRabbit
Chores
Refactor