Skip to content

fix: generate manifest in conformance with the deployment spec #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dud225
Copy link

@dud225 dud225 commented May 21, 2025

Summary by CodeRabbit

  • Chores

    • Updated application version metadata and documentation references from v0.38.0 to v0.39.0.
  • Refactor

    • Adjusted configuration so that the service name is now only included for StatefulSet resources in the deployment templates.

Copy link

coderabbitai bot commented May 21, 2025

Walkthrough

The changes update the graph-node Helm chart by bumping the application version from v0.38.0 to v0.39.0 in both the chart metadata and the README badge. Additionally, the Helm template logic is modified so that the serviceName field is only included in the spec when the resource kind is StatefulSet.

Changes

File(s) Change Summary
charts/graph-node/Chart.yaml, charts/graph-node/README.md Updated application version from v0.38.0 to v0.39.0 in chart metadata and README badge.
charts/graph-node/templates/graph-node/all.yaml Moved serviceName field inside the conditional for StatefulSet kind in the Helm template.

Sequence Diagram(s)

sequenceDiagram
    participant Helm Chart
    participant Kubernetes API

    Helm Chart->>Kubernetes API: Deploy resource
    alt If kind == StatefulSet
        Helm Chart->>Kubernetes API: Include serviceName in spec
    else Other kinds
        Helm Chart->>Kubernetes API: Do not include serviceName in spec
    end
Loading

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dud225 dud225 force-pushed the graph_node_schema branch from 2ab6fd2 to f5759e9 Compare May 21, 2025 12:55
@dud225 dud225 force-pushed the graph_node_schema branch from f5759e9 to 7c30c01 Compare May 21, 2025 12:56
@dud225 dud225 changed the title Fix schema non-conformance fix: generate manifest in conformance with the deployment spec May 21, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
charts/graph-node/Chart.yaml (1)

25-25: Chart appVersion updated correctly; consider bumping chart version
The appVersion has been bumped from v0.38.0 to v0.39.0, which aligns with the new Graph Node release. Per Helm SemVer best practices, please also increment the chart’s version (currently 0.5.9) to 0.5.10 to reflect this change in the chart artifacts.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between da54e00 and 7c30c01.

📒 Files selected for processing (3)
  • charts/graph-node/Chart.yaml (1 hunks)
  • charts/graph-node/README.md (1 hunks)
  • charts/graph-node/templates/graph-node/all.yaml (1 hunks)
🔇 Additional comments (2)
charts/graph-node/README.md (1)

5-5: Update version badge for AppVersion
The README badge for AppVersion has been updated to v0.39.0, keeping it in sync with Chart.yaml.

charts/graph-node/templates/graph-node/all.yaml (1)

65-74: Conditionally include serviceName only for StatefulSet
The serviceName (and accompanying StatefulSet properties) has been moved inside the if (eq $values.kind "StatefulSet") block to prevent schema non-conformance for other kinds (e.g., Deployment). Verify that indentation under spec: remains correct and that rendering with helm template or helm lint succeeds for both resource kinds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant