Remove label prop from scenario objects on stories. Update VR images. #10634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dundant-use-of-label-property-in-vrt-scenarios.
|
Build files for cc0c2aa are ready:
|
|
Size Change: 0 B Total Size: 2.06 MB ℹ️ View Unchanged
|
techanvil
requested changes
Apr 23, 2025
There was a problem hiding this comment.
Hey @juniovitorino, this PR has developed a few conflicts, please merge develop into it and resolve the conflicts.
Additionally, there are a number of instances of the following eslint-disable-next-line comment remaining in the codebase which can be removed, as the labels it was disabling the rule for have been removed:
// eslint-disable-next-line sitekit/no-storybook-scenario-label
…3-tidy-up-and-remove-redundant-use-of-label-property-in-vrt-scenarios.
juniovitorino
force-pushed
the
infrastructure/9103-tidy-up-and-remove-redundant-use-of-label-property-in-vrt-scenarios
branch
3 times, most recently
from
c730f9e to
c8e2af6
Compare
techanvil
requested changes
Apr 29, 2025
There was a problem hiding this comment.
Hey @juniovitorino, the VRT suite is failing in CI, with the failures including the Portugeuse-text SiWG button again.
I suspect the quick fix here is to copy the reference images from the report attached to the CI run.
Please, do remember to check the CI workflow statuses before moving a PR over to CR.
Thanks for the heads-up. I'm generating the images again—your suggestion didn’t work. Since a lot of the image names ended up changing, we’ll need new reference images. I’m now running |
Thanks @juniovitorino. Something else I've noticed while reviewing the changes (at the current commit, cc0c2aa) is that there are 110 images which have been modified rather than simply renamed. Here I'm diffing against 551d946 which is the commit for This one-liner will check out the old versions but doesn't account for renames: git checkout 5a6f988177 $(git diff 5a6f988177 | egrep 'Binary files.*differ' | grep -v '/dev/null' | cut -d \ -f 3 | cut -d / -f 2-)Changed image filesUpdate: Here's another one-liner to identify the files which were moved, so we should revert the changes and then move the unmodified versions of these: git diff 5a6f988177 | egrep 'Binary files.*differ' | grep -v '/dev/null' | while read -r line; do old=$(echo $line | cut -d \ -f 3 | cut -d / -f 2-); new=$(echo $line | cut -d \ -f 5 | cut -d / -f 2-); if [[ "$old" != "$new" ]]; then echo "$old renamed to $new" ; fi ; done
tests/backstop/reference/google-site-kit_Modules_Analytics4_Widgets_DashboardOverallPageMetricsWidgetGA4_LoadingEntityURL_0_document_2_large.png renamed to tests/backstop/reference/google-site-kit_Components_ReportErrorButton_Default_0_document_2_large.png
tests/backstop/reference/google-site-kit_KeyMetrics_ChangeMetricsLink_0_document_1_medium.png renamed to tests/backstop/reference/google-site-kit_Key_Metrics_ChangeMetricsLink_ChangeMetricsLink_0_document_1_medium.png
tests/backstop/reference/google-site-kit_KeyMetrics_ChangeMetricsLink_0_document_2_large.png renamed to tests/backstop/reference/google-site-kit_Key_Metrics_ChangeMetricsLink_ChangeMetricsLink_0_document_2_large.png
tests/backstop/reference/google-site-kit_KeyMetrics_MetricTileNumeric_Loading_0_document_1_medium.png renamed to tests/backstop/reference/google-site-kit_Key_Metrics_WidgetTiles_MetricTileNumeric_Loading_0_document_1_medium.png
tests/backstop/reference/google-site-kit_Modules_Analytics4_Components_AudienceSegmentation_Dashboard_AudienceSelectionPanel_AudienceCreationSuccessNotice_0_document_1_medium.png renamed to tests/backstop/reference/google-site-kit_Modules_Analytics4_Components_AudienceSegmentation_Dashboard_AudienceSelectionPanel_Audience_creation_success_notice_0_document_1_medium.png
tests/backstop/reference/google-site-kit_Modules_Analytics4_Components_AudienceSegmentation_Dashboard_AudienceSelectionPanel_AudienceCreationSuccessNotice_0_document_2_large.png renamed to tests/backstop/reference/google-site-kit_Modules_Analytics4_Components_AudienceSegmentation_Dashboard_AudienceSelectionPanel_Audience_creation_success_notice_0_document_2_large.png
tests/backstop/reference/google-site-kit_Modules_Analytics4_Widgets_DashboardAllTrafficWidgetGA4_EntityDashboard_Loading_0_document_1_medium.png renamed to tests/backstop/reference/google-site-kit_Modules_Analytics4_Widgets_All_Traffic_Widget_GA4_Entity_Dashboard_Loading_0_document_1_medium.png
tests/backstop/reference/google-site-kit_Modules_Analytics4_Widgets_DashboardAllTrafficWidgetGA4_MainDashboard_Loading_0_document_1_medium.png renamed to tests/backstop/reference/google-site-kit_Modules_Analytics4_Widgets_All_Traffic_Widget_GA4_Main_Dashboard_Loading_0_document_1_medium.png
tests/backstop/reference/google-site-kit_Modules_Analytics4_Widgets_DashboardOverallPageMetricsWidgetGA4_ZeroDataEntityURL_0_document_1_medium.png renamed to tests/backstop/reference/google-site-kit_Modules_Analytics4_Widgets_DashboardOverallPageMetricsWidgetGA4_Zero_Data_0_document_1_medium.png
tests/backstop/reference/google-site-kit_Modules_Analytics4_Widgets_DashboardOverallPageMetricsWidgetGA4_ZeroDataEntityURL_0_document_2_large.png renamed to tests/backstop/reference/google-site-kit_Modules_Analytics4_Widgets_DashboardOverallPageMetricsWidgetGA4_Zero_Data_0_document_2_large.png
tests/backstop/reference/google-site-kit_Modules_Analytics4_Widgets_DashboardOverallPageMetricsWidgetGA4_ZeroData_0_document_1_medium.png renamed to tests/backstop/reference/google-site-kit_Modules_Analytics4_Widgets_DashboardOverallPageMetricsWidgetGA4_Zero_Data_w__entity_URL_0_document_1_medium.png
tests/backstop/reference/google-site-kit_Modules_Analytics4_Widgets_DashboardOverallPageMetricsWidgetGA4_ZeroData_0_document_2_large.png renamed to tests/backstop/reference/google-site-kit_Modules_Analytics4_Widgets_DashboardOverallPageMetricsWidgetGA4_Zero_Data_w__entity_URL_0_document_2_large.png |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
labelproperty in VRT scenarios #9103Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist