Infra/10617 storybook service worker proxy poc #10632
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fy requests made by Storybook components.
techanvil
commented
Apr 14, 2025
| @@ -35,7 +35,7 @@ const path = require( 'path' ); | |||
| * Internal dependencies | |||
| */ | |||
| const storybookConfig = require( '../../storybook/main' ); | |||
| const rootURL = 'file:///src/dist/iframe.html?id='; | |||
| const rootURL = 'http://localhost:8001/iframe.html?id='; | |||
There was a problem hiding this comment.
We need to serve via HTTP for Chromium to provide support for service workers.
techanvil
commented
Apr 14, 2025
| self.addEventListener( 'fetch', ( event ) => { | ||
| const url = new URL( event.request.url ); | ||
|
|
||
| // Check if this is the Google Sign-In script. |
There was a problem hiding this comment.
I've hardwired a check for the SiWG script for the PoC, but this could be adapted to be config-driven for easier reuse.
1 task
techanvil
commented
Apr 14, 2025
| @@ -115,6 +119,18 @@ InvalidClientID.decorators = [ | |||
| export const Empty = Template.bind( null ); | |||
| Empty.storyName = 'Empty'; | |||
|
|
|||
| function WithServiceWorker( { children } ) { | |||
There was a problem hiding this comment.
Maybe the service worker registration should be applied in WithServiceWorker instead of globally. This WithServiceWorker component should be extracted for potential reuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Proof of concept for a proxy that allows intercepting requests made by Storybook components, targeting the https://accounts.google.com/gsi/client request in order to add the
hl=enquery parameter, ensuring the SiWG preview button is rendered in English regardless of the host IP's geo-location.Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist