-
Notifications
You must be signed in to change notification settings - Fork 1.3k
book: render the Persian translation right-to-left #2003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
book: render the Persian translation right-to-left #2003
Conversation
I also pushed it to my fork, so that https://dscho.github.io/git-scm.com/book/fa/v2 should show the effect once the deployment finishes. |
@YasinDehfuli could I ask you to have a look? |
Sure @dscho. Everything was correct based on my observation. The only issue that could be pointed out was that the book positioned at the top of the document with a fixed position on the right overlaps our titles when scrolling down. If this issue is fixed, then there’s nothing else to criticize. ![]() |
The Persian translation needs to be rendered right-to-left, as suggested in progit/progit2-fa#1 (comment). Signed-off-by: Johannes Schindelin <[email protected]>
9254e7c
to
a177856
Compare
@YasinDehfuli Excellent! You probably have experience with such positioning problems ;-) I fixed it via CSS. I also deployed this fix to my fork, you can see it in action here: https://dscho.github.io/git-scm.com/book/fa/v2 |
Great, now everything is working correctly. |
Excellent!
Unfortunately, I cannot help with that! |
No problem I will handle that |
dear @dscho. As you can see, The English Git version It would be better to add these new sections as well I should have asked: |
@YasinDehfuli Content (also headings) should be added to the book repository itself: https://github.com/progit/progit2
You're welcome, that would make our lives easier 😊 |
I guess that https://github.com/progit/progit2 has the newer sections, and https://github.com/progit/progit2-fa needs to "merge" them (by running something like Looking at the commit history (on GitHub, where investigations like this are hard), I believe that progit/progit2-fa@f801916 was the branch point (at least this commit is also here: progit/progit2@f801916). This looks a bit like a gargantuan task, though: there have been 755 commits in the English version (touching 172 files) since then: progit/progit2@f801916...main |
Changes
book/fa/v2/
right-to-left.Context
The Persian translation needs to be rendered right-to-left, as suggested in progit/progit2-fa#1 (comment).
Here is how it looks: