Skip to content

book: render the Persian translation right-to-left #2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

dscho
Copy link
Member

@dscho dscho commented May 12, 2025

@dscho
Copy link
Member Author

dscho commented May 12, 2025

I also pushed it to my fork, so that https://dscho.github.io/git-scm.com/book/fa/v2 should show the effect once the deployment finishes.

@dscho dscho marked this pull request as ready for review May 13, 2025 07:05
@dscho
Copy link
Member Author

dscho commented May 13, 2025

@YasinDehfuli could I ask you to have a look?

@YasinDehfuli
Copy link

Sure @dscho.

Everything was correct based on my observation.

The only issue that could be pointed out was that the book positioned at the top of the document with a fixed position on the right overlaps our titles when scrolling down. If this issue is fixed, then there’s nothing else to criticize.

image as you can see.

The Persian translation needs to be rendered right-to-left, as suggested
in progit/progit2-fa#1 (comment).

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho force-pushed the render-persian-translation-right-to-left branch from 9254e7c to a177856 Compare May 13, 2025 11:08
@dscho
Copy link
Member Author

dscho commented May 13, 2025

The only issue that could be pointed out was that the book positioned at the top of the document with a fixed position on the right overlaps our titles when scrolling down.

@YasinDehfuli Excellent! You probably have experience with such positioning problems ;-)

I fixed it via CSS. I also deployed this fix to my fork, you can see it in action here: https://dscho.github.io/git-scm.com/book/fa/v2

@YasinDehfuli
Copy link

Great, now everything is working correctly.
Now we can also start translating the other remaining parts.

@dscho
Copy link
Member Author

dscho commented May 13, 2025

Great, now everything is working correctly.

Excellent!

Now we can also start translating the other remaining parts.

Unfortunately, I cannot help with that!

@dscho dscho merged commit f1a98b0 into git:gh-pages May 13, 2025
1 check passed
@dscho dscho deleted the render-persian-translation-right-to-left branch May 13, 2025 13:05
@YasinDehfuli
Copy link

Unfortunately, I cannot help with that!

No problem I will handle that

@YasinDehfuli
Copy link

dear @dscho.

As you can see,

image

The English Git version
has newer sections that are unfortunately missing in the Persian version.

image

It would be better to add these new sections as well
so they can be translated in the future.

I should have asked:
Would you prefer that I do this myself?
Or would you rather take care of it yourself?

@To1ne
Copy link
Collaborator

To1ne commented May 27, 2025

It would be better to add these new sections as well
so they can be translated in the future.

@YasinDehfuli Content (also headings) should be added to the book repository itself: https://github.com/progit/progit2

I should have asked:
Would you prefer that I do this myself?
Or would you rather take care of it yourself?

You're welcome, that would make our lives easier 😊

@dscho
Copy link
Member Author

dscho commented May 27, 2025

I guess that https://github.com/progit/progit2 has the newer sections, and https://github.com/progit/progit2-fa needs to "merge" them (by running something like git pull https://github.com/progit/progit2 main and resolving the merge conflicts by adjusting the translations in accordance with the changes in the English book).

Looking at the commit history (on GitHub, where investigations like this are hard), I believe that progit/progit2-fa@f801916 was the branch point (at least this commit is also here: progit/progit2@f801916).

This looks a bit like a gargantuan task, though: there have been 755 commits in the English version (touching 172 files) since then: progit/progit2@f801916...main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants