Skip to content

Prepare for i686-only MINGW builds #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dscho
Copy link
Member

@dscho dscho commented May 5, 2025

In the context of git-for-windows/git#5401 ("Drop all i686 stuff from git-sdk-64"), this PR adjusts a few files so that the build-and-deploy workflow will run successfully in git-sdk-32 (it currently runs in git-sdk-64, unlike when the git-artifacts builds mingw-w64-i686-git, where git-sdk-32 is used already).

The build-and-deploy workflow will continue as before, as it will only make a difference when the architecture is set to i686 or x86_64 to build a MINGW package (and currently, the architecture is left empty for those).

dscho added 3 commits May 5, 2025 11:43
When deploying curl-8.11.0-2, a problem needed to be worked around:
that cURL version, v8.11.0, had a bug that needed to be fixed, but the
fix could not be deployed because of that bug. To work around this
problem, the `build-and-deploy` workflow needed to force-downgrade
the `curl` package.

This workaround is no longer needed, therefore we can drop it.

Signed-off-by: Johannes Schindelin <[email protected]>
When this workflow is run in "build-only" mode, we do not want to deploy
the package and therefore it is not necessary to check whether the
package has been deployed already.

Signed-off-by: Johannes Schindelin <[email protected]>
In the future, we want to build the packages in the appropriate git-sdk
for the given CPU architecture. Right now, we still build i686/x86_64
MINGW packages in git-sdk-64.

Let's respect the `ARCHITECTURE` environment variable (which is left
empty in the current workflow runs that want to build i686/x86_64 MINGW
packages), and set `MINGW_ARCH` appropriately when the `ARCHITECTURE`
is set to `i686` or `x86_64` (which we will do in the future).

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho self-assigned this May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant