Skip to content

Flat fix #3114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

Flat fix #3114

wants to merge 40 commits into from
+457 −12

Conversation

peardox
Copy link

@peardox peardox commented May 2, 2025

Fixingcommit conflicts

peardox added 30 commits April 23, 2025 18:48
@peardox
Add base of flat bindings - to expand
ebc8707
@peardox
Add and expose ggml_backend_try_load_best
2527199
@peardox
Add back previous closed PR code
e5184ae
@peardox
disable whisper_load_backends if GGML_BACKEND_DL - prevents the loadall
0510bb7
@peardox
Merge branch 'ggml-org:master' into bindings_flat
1f438d0
@peardox
Add whisper_flat_get_preferred_backend
1e7a15e
@peardox
Merge branch 'ggml-org:master' into bindings_flat
f603b5a
@peardox
Add whisper_get_backend_count and whisper_get_indexed_backend
7307aa7
@peardox
Merge branch 'bindings_flat' of https://github.com/WhisperBooks/whisp…
bdd8628 
…er.cpp into bindings_flat
@peardox
Merge branch 'ggml-org:master' into bindings_flat
8199e52
@peardox
OK, really finished - just enable examples via GGML_BACKEND_DL + BIND…
c37671c 
…INGS_FLAT
@peardox
Change type to size_t
c859e24
@peardox
Mac needs can't use GGML_BACKEND_DL, modify as needed
a0ccffa
@peardox
Forgot a few demos
b1ecac4
@peardox
Merge branch 'ggml-org:master' into bindings_flat
fe9e7d1
@peardox
Deployment tests
7ddd2f3
@peardox
fix cmakelists.txt
65d7b74
@peardox
Fix nullptr
53943bb
@peardox
Merge Timings into Activity
2ce178b
@peardox
Show ggml_backend_try_load_best in debug
0e1ebc0
@peardox
Show some var sizes
d381617
@peardox
Remove sizez again
6b51a3b
@peardox
Enable BACKEND_FLAT in 6 demos
660bee1
@peardox
ggml_backend_try_load_best only in BINDINGS_FLAT
94faab8
@peardox
Merge branch 'ggml-org:master' into flat
5ec6ad5
@peardox
Disable breaking MSVC Warning CMakeFiles.txt if GGML_CPU_ALL_VARIANTS
5a3b467
@peardox
Fix library load - update readme
f65e8b1
@peardox
Oops - accidental commit - fixup
d6c7a10
@peardox
Oops - accidental commit - fixup2
dffd00b
@peardox
Mend broken ifdef (one of mine)
24a8551
@peardox peardox mentioned this pull request May 2, 2025
Closed
@peardox
Copy link
Author

peardox commented May 5, 2025

@danbev your #3090 and others are now in master so will this get thru CI now?

I just merged and everything looks good

@peardox
Copy link
Author

peardox commented May 5, 2025

In CI Ruby don't like my -DBINDINGS_FLAT (which also creates a GGML_BINDINGS_FLAT)

The whole point of the switch is that it makes the additions / changes transparent to other systems

@KitaitiMakoto KitaitiMakoto mentioned this pull request May 5, 2025
Merged
@KitaitiMakoto
Copy link
Collaborator

KitaitiMakoto commented May 5, 2025 •
edited
Loading

@peardox Hi, I sent a pull request to fix Ruby problem to your branch: WhisperBooks#1

@peardox
Merge pull request #1 from KitaitiMakoto/ruby-options
f957031 
Fix for Ruby options

Thanks - I'm clueless regartding Ruby...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peardox @KitaitiMakoto