Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes get-convex/convex-backend#74
Currently, the react client depends directly on the
react-dom
package, specifically theunstable_batchedUpdates
implementation. This makes it impossible to use it onreact-native
only projects (with noreact-dom
installed).react-native
also implements this method, but it is obsolete since the react 18 release, with the implementation of Automatic batching (explained in more details here).A fix for this could be to test if the client is running react 17 and try o import
unstable_batchedUpdates
from eitherreact-dom
orreact-native
, but as discussed in the issue, a simpler solution could be to drop react 17 support, removing the need to useunstable_batchedUpdates
.This PR introduces these changes:
react-dom
from the peer dependenciesreact
unstable_batchedUpdates
in the react clienttransition
method.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.