Enforce ruff rules (RUF)

fsspec/__init__.py

@@ -16,21 +16,21 @@
 
 __all__ = [
     "AbstractFileSystem",
-    "FSTimeoutError",
+    "Callback",
     "FSMap",
+    "FSTimeoutError",
+    "available_compressions",
+    "available_protocols",
+    "caching",
     "filesystem",
-    "register_implementation",
     "get_filesystem_class",
     "get_fs_token_paths",
     "get_mapper",
     "open",
     "open_files",
     "open_local",
+    "register_implementation",
     "registry",
-    "caching",
-    "Callback",
-    "available_protocols",
-    "available_compressions",
     "url_to_fs",
 ]
 

fsspec/gui.py

@@ -169,8 +169,17 @@ def show(self, threads=False):
 class SingleSelect(SigSlot):
     """A multiselect which only allows you to select one item for an event"""
 
-    signals = ["_selected", "selected"]  # the first is internal
-    slots = ["set_options", "set_selection", "add", "clear", "select"]
+    signals: ClassVar[Sequence[str]] = [
+        "_selected",
+        "selected",
+    ]  # the first is internal
+    slots: ClassVar[Sequence[str]] = [
+        "set_options",
+        "set_selection",
+        "add",
+        "clear",
+        "select",
+    ]
 
     def __init__(self, **kwargs):
         self.kwargs = kwargs
@@ -212,7 +221,7 @@ class FileSelector(SigSlot):
     them as the output of a cell,  or in a separate browser tab using ``.show()``.
     """
 
-    signals = [
+    signals: ClassVar[Sequence[str]] = [
         "protocol_changed",
         "selection_changed",
         "directory_entered",
@@ -221,7 +230,7 @@ class FileSelector(SigSlot):
         "go_clicked",
         "filters_changed",
     ]
-    slots = ["set_filters", "go_home"]
+    slots: ClassVar[Sequence[str]] = ["set_filters", "go_home"]
 
     def __init__(self, url=None, filters=None, ignore=None, kwargs=None):
         """

fsspec/implementations/gist.py

@@ -141,16 +141,16 @@ def _get_kwargs_from_urls(path):
         """
         so = infer_storage_options(path)
         out = {}
-        if "username" in so and so["username"]:
+        if so.get("username"):
             out["username"] = so["username"]
-        if "password" in so and so["password"]:
+        if so.get("password"):
             out["token"] = so["password"]
-        if "host" in so and so["host"]:
+        if so.get("host"):
             # We interpret 'host' as the gist ID
             out["gist_id"] = so["host"]
 
         # Extract SHA and filename from path
-        if "path" in so and so["path"]:
+        if so.get("path"):
             path_parts = so["path"].rsplit("/", 2)[-2:]
             if len(path_parts) == 2:
                 if path_parts[0]:  # SHA present

fsspec/implementations/http.py

@@ -254,7 +254,7 @@ async def _get_file(
             if isfilelike(lpath):
                 outfile = lpath
             else:
-                outfile = open(lpath, "wb")  # noqa: ASYNC101, ASYNC230
+                outfile = open(lpath, "wb")  # noqa: ASYNC230
 
             try:
                 chunk = True
@@ -286,7 +286,7 @@ async def gen_chunks():
                 context = nullcontext(lpath)
                 use_seek = False  # might not support seeking
             else:
-                context = open(lpath, "rb")  # noqa: ASYNC101, ASYNC230
+                context = open(lpath, "rb")  # noqa: ASYNC230
                 use_seek = True
 
             with context as f:
@@ -812,7 +812,7 @@ async def get_range(session, url, start, end, file=None, **kwargs):
     async with r:
         out = await r.read()
     if file:
-        with open(file, "r+b") as f:  # noqa: ASYNC101, ASYNC230
+        with open(file, "r+b") as f:  # noqa: ASYNC230
             f.seek(start)
             f.write(out)
     else:

fsspec/implementations/memory.py

@@ -5,7 +5,7 @@
 from errno import ENOTEMPTY
 from io import BytesIO
 from pathlib import PurePath, PureWindowsPath
-from typing import Any, ClassVar
+from typing import Any, ClassVar, Sequence
 
 from fsspec import AbstractFileSystem
 from fsspec.implementations.local import LocalFileSystem
@@ -22,7 +22,7 @@ class MemoryFileSystem(AbstractFileSystem):
     """
 
     store: ClassVar[dict[str, Any]] = {}  # global, do not overwrite!
-    pseudo_dirs = [""]  # global, do not overwrite!
+    pseudo_dirs: ClassVar[Sequence[str]] = [""]  # global, do not overwrite!
     protocol = "memory"
     root_marker = "/"
 

fsspec/implementations/tests/conftest.py

@@ -10,7 +10,7 @@
 
 
 class MultiProtocolFileSystem(LocalFileSystem):
-    protocol = ["file", "other"]
+    protocol = ("file", "other")
 
 
 FILESYSTEMS = {

fsspec/implementations/tests/test_archive.py

@@ -214,14 +214,14 @@ class TestAnyArchive:
     will adhere to the same specification.
     """
 
-    scenarios = [
+    scenarios = (
         scenario_zip,
         scenario_tar,
         scenario_targz,
         scenario_tarbz2,
         scenario_tarxz,
         scenario_libarchive,
-    ]
+    )
 
     def test_repr(self, scenario: ArchiveTestScenario):
         with scenario.provider() as archive:

fsspec/registry.py

@@ -4,7 +4,7 @@
 import types
 import warnings
 
-__all__ = ["registry", "get_filesystem_class", "default"]
+__all__ = ["default", "get_filesystem_class", "registry"]
 
 # internal, mutable
 _registry: dict[str, type] = {}

fsspec/tests/conftest.py

@@ -6,6 +6,7 @@
 from collections import ChainMap
 from http.server import BaseHTTPRequestHandler, HTTPServer
 from types import SimpleNamespace
+from typing import ClassVar
 
 import pytest
 
@@ -45,7 +46,7 @@ def reset_files():
 
 
 class HTTPTestHandler(BaseHTTPRequestHandler):
-    static_files = {
+    static_files: ClassVar[dict[str, bytes]] = {
         "/index/realfile": data,
         "/index/otherfile": data,
         "/index": _make_index_listing,
@@ -55,7 +56,7 @@ class HTTPTestHandler(BaseHTTPRequestHandler):
         "/simple/dir/": _make_listing("/simple/dir/file"),
         "/simple/dir/file": data,
     }
-    dynamic_files = {}
+    dynamic_files: ClassVar[dict[str, bytes]] = {}
 
     files = ChainMap(dynamic_files, static_files)
 

fsspec/utils.py

@@ -174,7 +174,7 @@ def build_name_function(max_int: float) -> Callable[[int], str]:
     # handle corner cases max_int is 0 or exact power of 10
     max_int += 1e-8
 
-    pad_length = int(math.ceil(math.log10(max_int)))
+    pad_length = math.ceil(math.log10(max_int))
 
     def name_function(i: int) -> str:
         return str(i).zfill(pad_length)

pyproject.toml

@@ -177,9 +177,7 @@ select = [
     "PIE810",
     # "PT", enable in later PR
     "PYI",
-    "RUF006",
-    "RUF015",
-    "RUF024",
+    "RUF",
     "SIM",
     "SLOT",
     "SIM101",
@@ -213,6 +211,8 @@ ignore = [
     "UP011",
     "UP015",
     "UP018",
+    "RUF001",
+    "RUF005",
     "SIM102",
     "SIM105",
     "SIM108",